Localize signal snapshot source in notifications - #116
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b1f3440069
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| localize_price_source_label as _localize_price_source_label, | ||
| localize_quote_overlay_state as _localize_quote_overlay_state, |
There was a problem hiding this comment.
When the app is installed from requirements.txt, quant-platform-kit is pinned to 86d72631c76f27c668b234704b91241bec8fa9ee, whose notification_localization.py only exports localize_notification_text and translator_uses_zh; it does not define these newly imported helpers. In deployment or any fresh pip install -r requirements.txt environment, importing notifications.renderers will therefore raise ImportError before the app can start, even though CI may pass after installing an editable checkout of QuantPlatformKit main. Please either update the pinned dependency with this change or keep a local fallback here.
Useful? React with 👍 / 👎.
b1f3440 to
d2045cf
Compare
1 participant
Summary
Verification